Adds test coverage for Enumerated Entity Types support#340
Merged
muditchaudhary merged 2 commits intocedar-policy:mainfrom Dec 4, 2025
Merged
Conversation
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
Signed-off-by: Mudit Chaudhary <chmudit@amazon.com>
258abeb to
fabbdd2
Compare
shaobo-he-aws
approved these changes
Nov 10, 2025
| "permit(" | ||
| + " principal," | ||
| + " action == Action::\"CreateList\"," | ||
| + " resource == Application::\"TinyTODO\"" // Typo in enum value |
Contributor
There was a problem hiding this comment.
Nit: Is this case substantially different than givenEnumSchemaAndWrongCaseEnumValueReturnsInvalid?
Contributor
Author
There was a problem hiding this comment.
Actually not. We can remove one of these.
mark-creamer-amazon
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cedar 4.4 introduced Enumerated Entity Types, which allow entities to be restricted to a predefined set of values. While this feature requires no implementation changes in CedarJava, this PR adds test cases to verify the functionality works as expected with the existing codebase.